Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippy 4.4.0 #16003

Merged
merged 5 commits into from
Jun 20, 2019
Merged

Snippy 4.4.0 #16003

merged 5 commits into from
Jun 20, 2019

Conversation

greenkidneybean
Copy link
Contributor

@greenkidneybean greenkidneybean commented Jun 19, 2019

Hi @bioconda/core, this is a pull request to update the recipe for snippy in response to this issue, though I'm not sure the inclusion of java-jdk =8.0.112 in the meta.yaml is a working fix. I ran tests on branch snippy_4.4.0 via CircleCI and they appear to be passing. I've since turned off CircleCI builds on my fork.

For future reference, how would I go about testing the .tar.bz2 generated by conda-build?

  • I have read the guidelines for bioconda recipes.
  • This PR adds a new recipe.
  • AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
  • This PR updates an existing recipe.
  • This PR does something else (explain below).

@biocondabot
Copy link
Contributor

biocondabot bot commented Jun 19, 2019

Welcome to Bioconda, @greenkidneybean! Thank you for opening your first pull request! As you're new to Bioconda, please read through our documentation about contributing recipes. If you need help, please ping one of the following teams:

  • @bioconda/haskel for Haskell packages
  • @bioconda/lib for C/C++ packages
  • @bioconda/osx for help with builds erroring on OSX
  • @bioconda/perl for perl packages
  • @bioconda/python for python packages
  • @bioconda/r for R packages
  • @bioconda/rust for Rust packages
  • @bioconda/core in other cases

You can also join our Gitter channel to find help.

Please ping @bioconda/core when your pull request is passing tests and ready to be merged.

If you would like to join Bioconda, please mention that to @bioconda/core and they will happily send out an invitation link to you!

@dpryan79
Copy link
Contributor

Do you have circleci enabled on your fork? If so, I think that's preventing it from working for the PR.

@biocondabot
Copy link
Contributor

biocondabot bot commented Jun 19, 2019

Package(s) built on CircleCI are ready for inspection:

Arch Package Repodata
noarch snippy-4.4.0-1.tar.bz2 repodata.json

You may also use conda to install these:

  • For packages in noarch:
    conda install -c https://62221-42372094-gh.circle-artifacts.com/0/tmp/artifacts/packages <package name>
    

Docker image(s) built:

Package Tag Install with docker
snippy 4.4.0--1
showcurl "https://62221-42372094-gh.circle-artifacts.com/0/tmp/artifacts/images/snippy%3A4.4.0--1.tar.gz" | gzip -dc | docker load

@dpryan79
Copy link
Contributor

Does this really require java-jdk rather than openjdk?

@greenkidneybean
Copy link
Contributor Author

greenkidneybean commented Jun 19, 2019

I currently do not have circleci enabled on my fork, though it was enabled with i initially created the PR. I'll try the recipe with openjdk, @tseemann recommended using java-jdk as a fix for the issue and it worked. I've never used either and am in the dark on the difference between the two

@dpryan79
Copy link
Contributor

The most recent versions just pull in openjdk 8, so you might as well switch to using that directly.

@npavlovikj
Copy link
Member

On a side note, the build number should be increased to 1.

@epruesse
Copy link
Member

@BiocondaBot merge

@biocondabot
Copy link
Contributor

biocondabot bot commented Jun 20, 2019

Upload & Merge started. Reload page to view progress.

  • Checks OK
  • Fetching 1 packages and 1 images
  • Uploaded image biocontainers/snippy:4.4.0--1
  • Uploaded package noarch/snippy-4.4.0-1.tar.bz2
  • Creating squash merge (with co-authors @dpryan79)

@biocondabot biocondabot bot merged commit 710ad4e into bioconda:master Jun 20, 2019
@biocondabot
Copy link
Contributor

biocondabot bot commented Jun 20, 2019

@epruesse, your request to merge succeeded: Pull Request successfully merged

@greenkidneybean greenkidneybean deleted the snippy_4.4.0 branch July 2, 2019 13:28
kpalin pushed a commit to kpalin/bioconda-recipes that referenced this pull request Aug 7, 2019
Package uploads complete: [ci skip]
 - biocontainers/snippy:4.4.0--1
 - noarch/snippy-4.4.0-1.tar.bz2

Co-authored-by: Devon Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants