-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snippy 4.4.0 #16003
Snippy 4.4.0 #16003
Conversation
in hopes to address tseemann/snippy#259
Welcome to Bioconda, @greenkidneybean! Thank you for opening your first pull request! As you're new to Bioconda, please read through our documentation about contributing recipes. If you need help, please ping one of the following teams:
You can also join our Gitter channel to find help. Please ping If you would like to join Bioconda, please mention that to |
Do you have circleci enabled on your fork? If so, I think that's preventing it from working for the PR. |
Package(s) built on CircleCI are ready for inspection:
You may also use
Docker image(s) built:
|
Does this really require java-jdk rather than openjdk? |
I currently do not have circleci enabled on my fork, though it was enabled with i initially created the PR. I'll try the recipe with openjdk, @tseemann recommended using java-jdk as a fix for the issue and it worked. I've never used either and am in the dark on the difference between the two |
The most recent versions just pull in openjdk 8, so you might as well switch to using that directly. |
On a side note, the build number should be increased to 1. |
@BiocondaBot merge |
Upload & Merge started. Reload page to view progress.
|
@epruesse, your request to merge succeeded: Pull Request successfully merged |
Package uploads complete: [ci skip] - biocontainers/snippy:4.4.0--1 - noarch/snippy-4.4.0-1.tar.bz2 Co-authored-by: Devon Ryan <[email protected]>
Hi @bioconda/core, this is a pull request to update the recipe for snippy in response to this issue, though I'm not sure the inclusion of
java-jdk =8.0.112
in themeta.yaml
is a working fix. I ran tests on branchsnippy_4.4.0
via CircleCI and they appear to be passing. I've since turned off CircleCI builds on my fork.For future reference, how would I go about testing the .tar.bz2 generated by conda-build?