Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vardict update #15721

Merged
merged 5 commits into from
Jun 5, 2019
Merged

Vardict update #15721

merged 5 commits into from
Jun 5, 2019

Conversation

roryk
Copy link
Contributor

@roryk roryk commented Jun 4, 2019

Bioconda requires reviews prior to merging pull-requests (PRs). To facilitate this, once your PR is passing tests and ready to be merged, please add the please review & merge label so other members of the bioconda community can have a look at your PR and either make suggestions or merge it. Note that if you are not already a member of the bioconda project (meaning that you can't add this label), please ping @bioconda/core so that your PR can be reviewed and merged (please note if you'd like to be added to the bioconda project). Please see #15332 for more details.

  • I have read the guidelines for bioconda recipes.
  • This PR adds a new recipe.
  • AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
  • This PR updates an existing recipe.
  • This PR does something else (explain below).

@roryk
Copy link
Contributor Author

roryk commented Jun 4, 2019

Heya-- I fixed the lint checks for these recipes; for some reason bioconda is also complaining about some unrelated recipes, despite not having changed them. I can fix those in this or a separate PR if that would be helpful.

@druvus
Copy link
Member

druvus commented Jun 4, 2019

@bioconda-bot recheck

@biocondabot
Copy link
Contributor

biocondabot bot commented Jun 4, 2019

No artifacts found on recent CircleCI builds.

@roryk roryk added the please review & merge set to ask for merge label Jun 5, 2019
@roryk
Copy link
Contributor Author

roryk commented Jun 5, 2019

Squash and merge please, there are a bunch of ugly commits.

@bgruening bgruening merged commit 95913b6 into bioconda:master Jun 5, 2019
@roryk
Copy link
Contributor Author

roryk commented Jun 5, 2019

Thank you!

@roryk roryk deleted the vardict-update branch June 5, 2019 16:43
kpalin pushed a commit to kpalin/bioconda-recipes that referenced this pull request Aug 7, 2019
* Update vardict and vardict-java to v1.6.

* Add me as maintainer for vardict-java and vardict

* Build vardict with noarch: generic.

* Fix unrelated linting errors and the LICENSE warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants