genbank: add aarch64/arm64 builds #51448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
martin-g
added
aarch64
📝 WalkthroughWalkthroughThe pull request introduces modifications to the Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/genbank/meta.yaml (1)
38-41: LGTM: Additional platforms added as intended.The addition of 'linux-aarch64' and 'osx-arm64' to the 'additional-platforms' section directly addresses the PR objective of adding aarch64/arm64 builds. This change will enable the package to be built for ARM-based systems, which is excellent for expanding platform support.
Consider adjusting the indentation for better readability:
extra: additional-platforms: - linux-aarch64 - osx-arm64
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- recipes/genbank/meta.yaml (2 hunks)
🧰 Additional context used
🔇 Additional comments (3)
recipes/genbank/meta.yaml (3)
13-13: LGTM: Build number increment is appropriate.Incrementing the build number from 0 to 1 is correct when introducing changes to the package build process without changing the package version. This change aligns with the PR objective of adding aarch64/arm64 builds.
12-14: Verify intention: Removal of Python version skip condition.The skip condition
skip: True # [py < 36]has been removed. This allows the package to be built for Python versions below 3.6. Please confirm if this is intentional and if the package is now compatible with earlier Python versions.Could you provide more context on why this condition was removed? Are there any compatibility concerns with earlier Python versions?
Line range hint
1-41: Overall review: Changes align with PR objectives, one clarification needed.The changes to this file generally align well with the PR objective of adding aarch64/arm64 builds. The build number increment and addition of extra platforms are appropriate and well-implemented.
However, there's one point that requires clarification:
- The removal of the skip condition for Python versions below 3.6 is not explicitly mentioned in the PR objectives. Please confirm if this change is intentional and if there are any compatibility concerns with earlier Python versions.
Once this point is clarified, the changes look good to merge.
|
@BiocondaBot please fetch artifacts |
|
Package(s) built are ready for inspection:
Docker image(s) built:
|
LGTM! There are no CPU architecture specific libraries ... |
|
@BiocondaBot please add label |
rpetit3
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports(see here for the rationale and comprehensive explanation).Add a
run_exportssection like this:with
...being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}{{ pin_subpackage("myrecipe", max_pin="x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}while replacing
"myrecipe"with eithernameif aname|lowervariable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
Note that the
@BiocondaBot please mergecommand is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.