-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc | Post-deployment section: change method to get temp password #140
Merged
rodriguez-matias
merged 6 commits into
master
from
doc-flz-post-deployment-get-temp-passwd
Oct 5, 2022
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3597cd9
doc(first-steps/post-deployment): add new step to avoid errors with mfa
rodriguez-matias a85b809
doc(first-steps/post-deployment): update the information to make it m…
rodriguez-matias 5dc270a
doc(first-steps/post-deployment):update the method to get temp passwd.
rodriguez-matias 4fd1229
doc(first-steps/post-deployment): update information in credentials step
rodriguez-matias 5b9beb1
Merge branch 'doc-flz-post-deployment-profiles-mfa' of github.com:bin…
rodriguez-matias f119f8b
doc(first-steps/post-deployment): update -json flag command
rodriguez-matias File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rodriguez-matias Matu, I'm wondering why you've changed this command with the json output instead of the original one
CC: @angelofenoglio @juanmatias
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@exequielrafaela with the original method, in order to get the temp credentials , we need to do:
with the output -json command we can obtain the value of the temp passwd without make any change in the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rodriguez-matias I see, I think that is by design, so this seems to be some kind of workaround to skip that. But you have a good point that even if the
sensitive
property it's set to "True" we can skip that "secure" config.Let's discuss this along @angelofenoglio and @diego-ojeda-binbash in order to have their feedback.