-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc | Post-deployment section: change method to get temp password #140
Doc | Post-deployment section: change method to get temp password #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes, but overall looks good!
@angelofenoglio thanks for your valuable review :) |
…bashar/le-ref-architecture-doc into doc-flz-post-deployment-get-temp-passwd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
donde, changed in the other PR
leverage terraform output -json | ||
``` | ||
``` | ||
... | ||
user_natasha_romanoff_login_profile_encrypted_password = "SipVOzVtNTI0Ml...EZmJFxxQSteYQ==" | ||
user_natasha_romanoff_name = "natasha.romanoff" | ||
"user_natasha_romanoff_name": { | ||
"sensitive": false, | ||
"type": "string", | ||
"value": "natasha.romanoff" | ||
}, | ||
"user_natasha_romanoff_login_profile_encrypted_password": { | ||
"sensitive": true, | ||
"type": "string", | ||
"value": "wcDMAyRZJTaxw5v1AQwAy6c...............2mBIbNFxF1Tp/ilvyk8eEHvAA=" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rodriguez-matias Matu, I'm wondering why you've changed this command with the json output instead of the original one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@exequielrafaela with the original method, in order to get the temp credentials , we need to do:
- change the sensitive argument from true to false .
- Save the changes and then run the apply + output commands
- Then change it back again to sensitive = True
- And apply again the changes
with the output -json command we can obtain the value of the temp passwd without make any change in the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rodriguez-matias I see, I think that is by design, so this seems to be some kind of workaround to skip that. But you have a good point that even if the sensitive
property it's set to "True" we can skip that "secure" config.
Let's discuss this along @angelofenoglio and @diego-ojeda-binbash in order to have their feedback.
leverage terraform output -json | ||
``` | ||
``` | ||
... | ||
user_natasha_romanoff_login_profile_encrypted_password = "SipVOzVtNTI0Ml...EZmJFxxQSteYQ==" | ||
user_natasha_romanoff_name = "natasha.romanoff" | ||
"user_natasha_romanoff_name": { | ||
"sensitive": false, | ||
"type": "string", | ||
"value": "natasha.romanoff" | ||
}, | ||
"user_natasha_romanoff_login_profile_encrypted_password": { | ||
"sensitive": true, | ||
"type": "string", | ||
"value": "wcDMAyRZJTaxw5v1AQwAy6c...............2mBIbNFxF1Tp/ilvyk8eEHvAA=" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rodriguez-matias I see, I think that is by design, so this seems to be some kind of workaround to skip that. But you have a good point that even if the sensitive
property it's set to "True" we can skip that "secure" config.
Let's discuss this along @angelofenoglio and @diego-ojeda-binbash in order to have their feedback.
What?
For this this step it must say: Change output sensitive argument from
true
tofalse
, to be able to show the encrypted passwd.But then we also need add some comment to change it back again once we get the tmp passwd.
I think another better option, is to directly run the output with the --json flag like this :
leverage terraform output --json
This command shows you the value without the need for any code changes .
Where?
https://leverage.binbash.com.ar/first-steps/post-deployment/#get-the-temporary-password-to-access-aws-console
Change Preview