Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc | Post-deployment section: change method to get temp password #140

Merged
merged 6 commits into from
Oct 5, 2022

Conversation

rodriguez-matias
Copy link
Contributor

What?

  • For this this step it must say: Change output sensitive argument from true to false, to be able to show the encrypted passwd.

  • But then we also need add some comment to change it back again once we get the tmp passwd.

  • I think another better option, is to directly run the output with the --json flag like this :
    leverage terraform output --json
    This command shows you the value without the need for any code changes .

Where?

Change Preview

image

@rodriguez-matias rodriguez-matias requested a review from a team as a code owner September 24, 2022 14:38
@rodriguez-matias rodriguez-matias self-assigned this Sep 24, 2022
@rodriguez-matias rodriguez-matias added documentation Improvements or additions to documentation patch labels Sep 24, 2022
Copy link
Contributor

@angelofenoglio angelofenoglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes, but overall looks good!

docs/first-steps/post-deployment.md Outdated Show resolved Hide resolved
docs/first-steps/post-deployment.md Outdated Show resolved Hide resolved
docs/first-steps/post-deployment.md Outdated Show resolved Hide resolved
docs/first-steps/post-deployment.md Outdated Show resolved Hide resolved
@exequielrafaela
Copy link
Member

@angelofenoglio thanks for your valuable review :)

Copy link
Contributor Author

@rodriguez-matias rodriguez-matias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

donde, changed in the other PR

docs/first-steps/post-deployment.md Outdated Show resolved Hide resolved
Comment on lines +26 to +39
leverage terraform output -json
```
```
...
user_natasha_romanoff_login_profile_encrypted_password = "SipVOzVtNTI0Ml...EZmJFxxQSteYQ=="
user_natasha_romanoff_name = "natasha.romanoff"
"user_natasha_romanoff_name": {
"sensitive": false,
"type": "string",
"value": "natasha.romanoff"
},
"user_natasha_romanoff_login_profile_encrypted_password": {
"sensitive": true,
"type": "string",
"value": "wcDMAyRZJTaxw5v1AQwAy6c...............2mBIbNFxF1Tp/ilvyk8eEHvAA="
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rodriguez-matias Matu, I'm wondering why you've changed this command with the json output instead of the original one

CC: @angelofenoglio @juanmatias

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@exequielrafaela with the original method, in order to get the temp credentials , we need to do:

  • change the sensitive argument from true to false .
  • Save the changes and then run the apply + output commands
  • Then change it back again to sensitive = True
  • And apply again the changes

with the output -json command we can obtain the value of the temp passwd without make any change in the code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rodriguez-matias I see, I think that is by design, so this seems to be some kind of workaround to skip that. But you have a good point that even if the sensitive property it's set to "True" we can skip that "secure" config.

Let's discuss this along @angelofenoglio and @diego-ojeda-binbash in order to have their feedback.

Comment on lines +26 to +39
leverage terraform output -json
```
```
...
user_natasha_romanoff_login_profile_encrypted_password = "SipVOzVtNTI0Ml...EZmJFxxQSteYQ=="
user_natasha_romanoff_name = "natasha.romanoff"
"user_natasha_romanoff_name": {
"sensitive": false,
"type": "string",
"value": "natasha.romanoff"
},
"user_natasha_romanoff_login_profile_encrypted_password": {
"sensitive": true,
"type": "string",
"value": "wcDMAyRZJTaxw5v1AQwAy6c...............2mBIbNFxF1Tp/ilvyk8eEHvAA="
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rodriguez-matias I see, I think that is by design, so this seems to be some kind of workaround to skip that. But you have a good point that even if the sensitive property it's set to "True" we can skip that "secure" config.

Let's discuss this along @angelofenoglio and @diego-ojeda-binbash in order to have their feedback.

@rodriguez-matias rodriguez-matias merged commit e56e186 into master Oct 5, 2022
@rodriguez-matias rodriguez-matias deleted the doc-flz-post-deployment-get-temp-passwd branch October 5, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants