Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Update snakemake to v8 #493

Draft
wants to merge 115 commits into
base: main
Choose a base branch
from
Draft

feat!: Update snakemake to v8 #493

wants to merge 115 commits into from

Conversation

tedil
Copy link
Member

@tedil tedil commented Mar 25, 2024

This PR updates snakemake to version 8.

ToDo

  • adapt to snakemake API changes
  • use modules instead of subworkflows
  • update environment yaml and requirements files
  • merge requirements files into environment.yaml as much as possible
  • use slurm executor plugin instead of custom job submission scripts

Miscellaneous

  • renames all rule alls to rule ${WORKFLOW}_all and sets default_target: True for those. In principle, we could simply get rid of the ${WORKFLOW} prefix for all rules, since the module system allows specifying a custom prefix.

Copy link

github-actions bot commented Apr 9, 2024

  • Please format your Python code with ruff: make fmt
  • Please check your Python code with ruff: make check
  • Please format your Snakemake code with snakefmt: make snakefmt

You can trigger all lints locally by running make lint

@coveralls
Copy link

coveralls commented Dec 10, 2024

Coverage Status

coverage: 85.772% (+0.002%) from 85.77%
when pulling ee4cbe1 on snake8
into 0d03919 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants