fix: Revel score for nonsense variant (#126) (#139)

bihealth · Oct 17, 2023 · d501d98 · d501d98
1 parent bc251d3
commit d501d98
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 15 deletions.
diff --git a/backend/Pipfile b/backend/Pipfile
@@ -23,6 +23,7 @@ uvicorn = "*"
 alembic = "*"
 requests = "*"
 types-requests = "*"
+greenlet = "*"
 
 [dev-packages]
 aiosqlite = "*"

diff --git a/backend/Pipfile.lock b/backend/Pipfile.lock
diff --git a/frontend/src/components/VariantDetails/ScoreDisplay.vue b/frontend/src/components/VariantDetails/ScoreDisplay.vue
@@ -173,14 +173,13 @@ const getColorByName = (name: string): string => {
       return getColorByValue(0.88)
     case 'pathogenicVeryStrong':
       return getColorByValue(1)
+    default:
+      return 'white'
   }
-  return 'white'
 }
 
 const circleFill = computed((): string => {
-  if (props.value === null) {
-    return 'white'
-  } else if (props.benignVeryStrongUpper !== null && props.value < props.benignVeryStrongUpper) {
+  if (props.benignVeryStrongUpper !== null && props.value < props.benignVeryStrongUpper) {
     return getColorByName('benignVeryStrong')
   } else if (props.benignStrongUpper !== null && props.value < props.benignStrongUpper) {
     return getColorByName('benignStrong')

diff --git a/frontend/src/components/VariantDetails/VariantTools.vue b/frontend/src/components/VariantDetails/VariantTools.vue
@@ -53,12 +53,15 @@ const decodeMultiDbnsfp = (s: string): number | null => {
   if (!s) {
     return null
   } else {
-    return Math.max(
-      ...s
-        .split(';')
-        .filter((s) => s != '.')
-        .map(parseFloat)
-    )
+    const vals = s
+      .split(';')
+      .filter((s) => s != '.')
+      .map(parseFloat)
+    if (!vals.length) {
+      return null
+    } else {
+      return Math.max(...vals)
+    }
   }
 }