-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: irods download refactoring and new generic sodar downloader with preset for dragen data (#226 ) #227
feat: irods download refactoring and new generic sodar downloader with preset for dragen data (#226 ) #227
Conversation
Added new PullDataCollection command
Please format your code with black: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
==========================================
+ Coverage 81.05% 81.50% +0.45%
==========================================
Files 106 108 +2
Lines 8212 8380 +168
==========================================
+ Hits 6656 6830 +174
+ Misses 1556 1550 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments from my side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't really comment on the logic here, as I am not particularly familiar with irods, so most of my comments are small-ish and optional suggestions (regarding type hints and generators instead of list comprehensions).
I didn't mark all type hints, but with python 3.10+ (which I think is the minimum requirement for cubi-tk), you can simply use the builtin directly, no need to import from typing for most of them.
Fixes #226
Replaces #208
Partially fixes #201