Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: irods download refactoring and new generic sodar downloader with preset for dragen data (#226 ) #227

Merged
merged 11 commits into from
Apr 8, 2024

Conversation

Nicolai-vKuegelgen
Copy link
Contributor

Fixes #226
Replaces #208

Partially fixes #201

@Nicolai-vKuegelgen Nicolai-vKuegelgen linked an issue Mar 11, 2024 that may be closed by this pull request
@Nicolai-vKuegelgen Nicolai-vKuegelgen changed the title Feat: irods download refactoring and new generic sodar downloader with preset for dragen data (#226 ) feat: irods download refactoring and new generic sodar downloader with preset for dragen data (#226 ) Mar 11, 2024
Copy link
Contributor

Please format your code with black: make black.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 77.73973% with 65 lines in your changes are missing coverage. Please review.

Project coverage is 81.50%. Comparing base (0f7f5b2) to head (cbf69e3).

❗ Current head cbf69e3 differs from pull request most recent head 447c235. Consider uploading reports for the commit 447c235 to get more accurate results

Files Patch % Lines
cubi_tk/sodar/pull_data_collection.py 70.07% 38 Missing ⚠️
cubi_tk/irods_common.py 70.00% 15 Missing ⚠️
cubi_tk/irods/check.py 42.85% 4 Missing ⚠️
cubi_tk/snappy/pull_data_common.py 80.00% 2 Missing ⚠️
cubi_tk/snappy/check_remote.py 50.00% 1 Missing ⚠️
cubi_tk/snappy/pull_processed_data.py 50.00% 1 Missing ⚠️
cubi_tk/snappy/pull_raw_data.py 50.00% 1 Missing ⚠️
cubi_tk/sodar/check_remote.py 50.00% 1 Missing ⚠️
cubi_tk/sodar_common.py 85.71% 1 Missing ⚠️
tests/test_sodar_pull_data_collection.py 98.38% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
+ Coverage   81.05%   81.50%   +0.45%     
==========================================
  Files         106      108       +2     
  Lines        8212     8380     +168     
==========================================
+ Hits         6656     6830     +174     
+ Misses       1556     1550       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@xiamaz xiamaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments from my side

cubi_tk/sodar/pull_data_collection.py Show resolved Hide resolved
cubi_tk/sodar/pull_data_collection.py Outdated Show resolved Hide resolved
cubi_tk/sodar/pull_data_collection.py Outdated Show resolved Hide resolved
Copy link
Member

@xiamaz xiamaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Nicolai-vKuegelgen Nicolai-vKuegelgen removed the request for review from sellth April 3, 2024 13:06
@Nicolai-vKuegelgen Nicolai-vKuegelgen marked this pull request as ready for review April 8, 2024 08:47
@Nicolai-vKuegelgen Nicolai-vKuegelgen requested a review from tedil April 8, 2024 08:56
Copy link
Member

@tedil tedil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really comment on the logic here, as I am not particularly familiar with irods, so most of my comments are small-ish and optional suggestions (regarding type hints and generators instead of list comprehensions).
I didn't mark all type hints, but with python 3.10+ (which I think is the minimum requirement for cubi-tk), you can simply use the builtin directly, no need to import from typing for most of them.

cubi_tk/irods_common.py Outdated Show resolved Hide resolved
cubi_tk/irods_common.py Show resolved Hide resolved
cubi_tk/irods_common.py Outdated Show resolved Hide resolved
cubi_tk/sodar/pull_data_collection.py Outdated Show resolved Hide resolved
cubi_tk/sodar/pull_data_collection.py Outdated Show resolved Hide resolved
cubi_tk/sodar/pull_data_collection.py Outdated Show resolved Hide resolved
cubi_tk/sodar/pull_data_collection.py Outdated Show resolved Hide resolved
cubi_tk/sodar/pull_data_collection.py Outdated Show resolved Hide resolved
cubi_tk/sodar/pull_data_collection.py Outdated Show resolved Hide resolved
cubi_tk/sodar/pull_data_collection.py Outdated Show resolved Hide resolved
@Nicolai-vKuegelgen Nicolai-vKuegelgen merged commit 3fc38af into main Apr 8, 2024
4 checks passed
@Nicolai-vKuegelgen Nicolai-vKuegelgen deleted the 226-new-sodar-downloader-for-dragen-data branch April 8, 2024 12:19
This was referenced Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor commonly use functionality, esp. from cubi-tk snappy New sodar downloader for Dragen data
3 participants