-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Common functions for interfacing with python-irodsclient #202
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
==========================================
+ Coverage 77.84% 79.84% +2.00%
==========================================
Files 98 100 +2
Lines 7330 7701 +371
==========================================
+ Hits 5706 6149 +443
+ Misses 1624 1552 -72 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good overall only a few minor comments.
Would be good if someone who understands mock testing in python better than me could review that part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
though as of now this will be unused right?
Should pick a 1-2 functions and implement it there and then start rolling out where needed/possible
I could dress up my "SODAR ingest anything" function as a pilot use case, but maybe we want to separate those PRs? Might be worth implementing the get functionality though. |
fixes #200
CAT_PASSWORD_EXPIRED
for long transfersNote: Uploads cannot be cancelled by KeyboardInterrupt (caused by multiprocessing in irods client)