cleanup & fix st7920 simulator (add klipper support) #705

Msq001 · 2020-05-23T07:48:13Z

Description

cleanup st7920, Fix occasional display offset bug
st7920 simulator add support for klipper(Now the support is not perfect, because the compatibility problem, default code is used with Marlin, and if you want to use with kipper needs additional modification code).
- if you use TFT24 V1.1, modify stm32f10x hal
  if you use TFT35 V3.0 etc.., modify stm32f2xx hal
  from SPI_ReEnable(!!(GPIOB->IDR & (1<<13))); to SPI_ReEnable(0);(because Marlin lpc176x st7920 spi is mode 0, but avr & stm32 is mode3, so marlin need to adapt by itself, but klipper is mode0, and the logic of SCK seems abnormal, so it cannot adapt, please set to mode 0 directly)
- please modify void ST7920_DrawGDRAM(uint8_t data) function from

void ST7920_DrawGDRAM(uint8_t data)
{
  if (st7920_reg.fs.g != 1) return; // Graphic display off
  for (uint8_t i = 0; i < 8; i++) {
    if (data & 0x80)
      ST7920_DrawPixel(st7920.x, st7920.y, true);
    else
      ST7920_DrawPixel(st7920.x, st7920.y, false);
    data <<= 1;
    st7920.x++;
  }
  if (st7920.x >= 128) {
    st7920.x = 0;
    st7920.y = (st7920.y + 32);
    if (st7920.y >= 64) st7920.y = (st7920.y + 1) & (64 - 1);
  }
}

to

void ST7920_DrawGDRAM(uint8_t data)
{
  if (st7920_reg.fs.g != 1) return; // Graphic display off
  for (uint8_t i = 0; i < 8; i++) {
    if (data & 0x80)
      ST7920_DrawPixel(st7920.x, st7920.y, true);
    data <<= 1;
    st7920.x++;
  }
  if (st7920.x >= 128) {
    st7920.x = 0;
    st7920.y = (st7920.y + 32);
    if (st7920.y >= 64) st7920.y = (st7920.y + 1) & (64 - 1);
  }
}

There are still some unsolved bugs in the parts supporting klipper
- The dynamic display of fan is abnormal in CGRAM when fan speed not 0
- When the temperature changes in the status menu, the symbol of ° will be covered by space
- klipper st7920 fonts is stored in stm32 flash, this is temporary. next PR will move it to W25qxx, which is convenient for users to customize fonts

Benefits

Related Issues

#290

vodic62 · 2020-05-23T16:16:20Z

Hi, thank you a lot for this commit. I already updated my TFT24 firmware, but my display is black most of the time. Only some times (once a day) it draws graphics on the display (works ok with Marlin). Same beahaviour I had with previous version o TFT24 firmware. Is my Klipper printer.cfg configuration of Bigtreetech SKR 1.3 board ok?

[board_pins]
aliases:
# EXP1 header
EXP1_1=P1.30, EXP1_3=P1.18, EXP1_5=P1.20, EXP1_7=P1.22, EXP1_9=,
EXP1_2=P0.28, EXP1_4=P1.19, EXP1_6=P1.21, EXP1_8=P1.23, EXP1_10=<5V>,
# EXP2 header
EXP2_1=P0.17, EXP2_3=P3.26, EXP2_5=P3.25, EXP2_7=P1.31, EXP2_9=,
EXP2_2=P0.15, EXP2_4=P0.16, EXP2_6=P0.18, EXP2_8=, EXP2_10=
# Pins EXP2_1, EXP2_6, EXP2_2 are also MISO, MOSI, SCK of bus "ssp0"

[display]
lcd_type: st7920
cs_pin: EXP1_4
sclk_pin: EXP1_5
sid_pin: EXP1_3
encoder_pins: ^!EXP2_3, ^!EXP2_5
click_pin: ^EXP1_2
kill_pin: ^!EXP2_8

* master: cleanup & fix st7920 simulator (add klipper support) (bigtreetech#705) Add detection of Mainboard firmware type( Marlin or Smoothieware), auto-detect LONG_FILENAME_HOST_SUPPORT, on-boardSD and serial_always_on option in config file & other bugfixes (bigtreetech#663) Aesthetics, language, configuration (bigtreetech#667) Fix send_cancel_gcode in abortPrinting (bigtreetech#672) Fix heater indexes (bigtreetech#670) RU language correction (bigtreetech#701) Fix a few typos and add missing translations (bigtreetech#694)

dushyantahuja · 2020-05-25T07:17:25Z

Same here - just uploaded the latest firmware to my TFT24 (compiled from the latest source) - and have the following in my config - I have a BTT SKR1.4 Turbo:

[board_pins]
aliases:
    # EXP1 header
    EXP1_1=P1.30, EXP1_3=P1.18, EXP1_5=P1.20, EXP1_7=P1.22, EXP1_9=<GND>,
    EXP1_2=P0.28, EXP1_4=P1.19, EXP1_6=P1.21, EXP1_8=P1.23, EXP1_10=<5V>,
    # EXP2 header
    EXP2_1=P0.17, EXP2_3=P3.26, EXP2_5=P3.25, EXP2_7=P1.31, EXP2_9=<GND>,
    EXP2_2=P0.15, EXP2_4=P0.16, EXP2_6=P0.18, EXP2_8=<RST>, EXP2_10=<NC>
    # Pins EXP2_1, EXP2_6, EXP2_2 are also MISO, MOSI, SCK of bus "ssp0"

[display]
lcd_type: st7920
cs_pin: EXP1_4
sclk_pin: EXP1_5
sid_pin: EXP1_3
encoder_pins: ^EXP2_3, ^EXP2_5
click_pin: ^!EXP1_2
#kill_pin: ^!EXP2_8

Still doesn't work - I just get a blank screen with "LCD12864 simulator" on top
Has anyone got it working - can you please advise if I've got the pins wrong, or maybe something else.

Msq001 · 2020-05-25T09:16:19Z

Hello have modify here

st7920 simulator add support for klipper(Now the support is not perfect, because the compatibility problem, default code is used with Marlin, and if you want to use with kipper needs additional modification code).

if you use TFT24 V1.1, modify stm32f10x hal
if you use TFT35 V3.0 etc.., modify stm32f2xx hal
from SPI_ReEnable(!!(GPIOB->IDR & (1<<13))); to SPI_ReEnable(0);(because Marlin lpc176x st7920 spi is mode 0, but avr & stm32 is mode3, so marlin need to adapt by itself, but klipper is mode0, and the logic of SCK seems abnormal, so it cannot adapt, please set to mode 0 directly)

it's very important!

fix st7920 bugs after #705

vodic62 · 2020-05-25T09:28:32Z

I have followed your instructions and made modifications of spi_slave.c and ST7920_Simulator.c and compiled. Last week with old revision (without font support) I had black screen with occasional draw of graphics without fonts. With this latest revision with modifications from description I have black screen also, but I had no graphics redraw ever till now. Only some garbage on screen with some changes when rotating encoder happened yesterday. I have TFT24 V1.1 and SKR 1.3.

Msq001 · 2020-05-25T13:19:00Z

Hello, please try this .bin firmware.
BIGTREE_TFT24_V1.1.26.1.zip

if it's ok, please set SPI_ReEnable(!!(GPIOB->IDR & (1<<13))); to SPI_ReEnable(1) not SPI_ReEnable(0) for TFT24 V1.1

dushyantahuja · 2020-05-25T13:23:25Z

Great, thanks - this works great.

vodic62 · 2020-05-25T19:21:27Z

I can confirm that when I made fresh git clone and made instructed modification my display started to work. Thank you.

Tygrys-1 · 2020-06-01T18:59:03Z

Can this be related to #735 ?

dushyantahuja · 2020-06-10T07:21:59Z

hmmm - it's still not perfect - especially when you reset the printer using the reset button on the TFT. Refuses to show anything after that.

* fix bug * improve st7920 simulator for klipper

fix st7920 bugs after bigtreetech#705

DroneMang · 2020-10-07T18:08:08Z

if it's ok, please set SPI_ReEnable(!!(GPIOB->IDR & (1<<13))); to SPI_ReEnable(1) not SPI_ReEnable(0) for TFT24 V1.1

With this mod and recompile from BTT display works!

rizwansarwar · 2020-10-09T15:23:30Z

It does not still work properly. My screen sometimes shows up, sometimes it disappears completely and sometimes it shows total garbage on the screen. I think your fix does not totally fix the real issue.

DroneMang · 2020-10-09T17:57:25Z

I agree. I have to restart the firmware and klipper multiple times to get something to show on the screen sometimes. Also the print progress was not updating during a print. Hopefully this gets fixed! Thanks.

…

On Fri, Oct 9, 2020, 11:23 AM Rizwan Sarwar ***@***.***> wrote: It does not still work properly. My screen sometimes shows up, sometimes it disappears completely and sometimes it shows total garbage on the screen. I think your fix does not totally fix the real issue. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#705 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIZZJSCYEQUJULQNPZFATUDSJ4TILANCNFSM4NIK4GSQ> .

Bl00d0und4 · 2021-06-27T11:55:40Z

Someone have a Wire Diagramm Form TFT24 v1.1?

unknown and others added 3 commits May 12, 2020 16:20

fix bug

21a0350

improve st7920 simulator for klipper

236c497

Merge branch 'master' into master

2350393

bigtreetech merged commit e6d8218 into bigtreetech:master May 23, 2020

Msq001 mentioned this pull request May 25, 2020

fix st7920 bug after (#705) #714

Merged

bigtreetech pushed a commit that referenced this pull request May 25, 2020

fix st7920 bug (#714)

9c981c5

fix st7920 bugs after #705

bigtreetech mentioned this pull request May 25, 2020

[BUG] LIGHTWEIGHT_UI not working correctly #683

Closed

dushyantahuja mentioned this pull request May 25, 2020

BigTreetech TFT 24 not working Klipper3d/klipper#2231

Closed

jeffeb3 pushed a commit to jeffeb3/BIGTREETECH-TouchScreenFirmware that referenced this pull request Jul 20, 2020

cleanup & fix st7920 simulator (add klipper support) (bigtreetech#705)

129ddcf

* fix bug * improve st7920 simulator for klipper

jeffeb3 pushed a commit to jeffeb3/BIGTREETECH-TouchScreenFirmware that referenced this pull request Jul 20, 2020

fix st7920 bug (bigtreetech#714)

dcf4ddf

fix st7920 bugs after bigtreetech#705

jakep82 mentioned this pull request Oct 6, 2020

SKR Pro display doesn't work, hotend PID integrator windup, firmware retract disregards retract speed Klipper3d/klipper#3405

Closed

bigtreetech mentioned this pull request Apr 12, 2021

TO DO List #1830

Closed

8 tasks

radek8 mentioned this pull request Oct 18, 2021

SKR MINI E3 V2 AND BIGTREE TFT E3 V3 #2217

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cleanup & fix st7920 simulator (add klipper support) #705

cleanup & fix st7920 simulator (add klipper support) #705

Msq001 commented May 23, 2020 •

edited

Loading

vodic62 commented May 23, 2020

dushyantahuja commented May 25, 2020 •

edited

Loading

Msq001 commented May 25, 2020

vodic62 commented May 25, 2020 •

edited

Loading

Msq001 commented May 25, 2020

dushyantahuja commented May 25, 2020

vodic62 commented May 25, 2020

Tygrys-1 commented Jun 1, 2020

dushyantahuja commented Jun 10, 2020

DroneMang commented Oct 7, 2020 •

edited

Loading

rizwansarwar commented Oct 9, 2020

DroneMang commented Oct 9, 2020 via email

Bl00d0und4 commented Jun 27, 2021

cleanup & fix st7920 simulator (add klipper support) #705

cleanup & fix st7920 simulator (add klipper support) #705

Conversation

Msq001 commented May 23, 2020 • edited Loading

Description

Benefits

Related Issues

vodic62 commented May 23, 2020

dushyantahuja commented May 25, 2020 • edited Loading

Msq001 commented May 25, 2020

vodic62 commented May 25, 2020 • edited Loading

Msq001 commented May 25, 2020

dushyantahuja commented May 25, 2020

vodic62 commented May 25, 2020

Tygrys-1 commented Jun 1, 2020

dushyantahuja commented Jun 10, 2020

DroneMang commented Oct 7, 2020 • edited Loading

rizwansarwar commented Oct 9, 2020

DroneMang commented Oct 9, 2020 via email

Bl00d0und4 commented Jun 27, 2021

Msq001 commented May 23, 2020 •

edited

Loading

dushyantahuja commented May 25, 2020 •

edited

Loading

vodic62 commented May 25, 2020 •

edited

Loading

DroneMang commented Oct 7, 2020 •

edited

Loading