Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix send_cancel_gcode in abortPrinting #672

Merged
merged 1 commit into from
May 23, 2020
Merged

Fix send_cancel_gcode in abortPrinting #672

merged 1 commit into from
May 23, 2020

Conversation

rebel1
Copy link
Contributor

@rebel1 rebel1 commented May 9, 2020

Description

Fix misplaced send_cancel_gcode in abortPrinting

Benefits

Enabled Cancel Gcode works now as expected, before it was not executed

Related Issues

Cancel Gcode doesn´t work on TFT-SD and U_DISK

@guruathwal
Copy link
Contributor

this change was done to prevent sending cancel gcode when printing from onboard SDCard as @thisiskeithb reported that the cancel code was doubling up.

@thisiskeithb
Copy link
Contributor

Marlin has it's own cancel gcode, so the TFT's cancel gcode should be optional.

@oldman4U oldman4U mentioned this pull request May 14, 2020
Closed
@digant73
Copy link
Contributor

digant73 commented May 14, 2020 •
edited
Loading

this change was done to prevent sending cancel gcode when printing from onboard SDCard as @thisiskeithb reported that the cancel code was doubling up.

On my side it seems the cancel gcode is not executed even if send_cancel_gcode is enabled from the feature menu. Tested printing from SD card (so gcode should be executed when enabled on infoSettings.send_cancel_gcode). I see in the source code that the hard coded gcode defined in PRINT_CANCEL_GCODE should be executed when a print is aborted although the cancel_gcode is configurable in the config.ini. Maybe a bug or the feature is not yet totally implemented.
However, in order the cancel gcode is executed I must comment out the instruction clearCmdQueue(); following mustStoreCmd(PRINT_CANCEL_GCODE); or put clearCmdQueue(); at the beginning of the abortPrinting() function.

@digant73
Copy link
Contributor

it was also fixed by PR #663

@bigtreetech bigtreetech merged commit caaf378 into bigtreetech:master May 23, 2020
delwinbest added a commit to delwinbest/BIGTREETECH-TouchScreenFirmware that referenced this pull request May 25, 2020
@delwinbest
Merge branch 'master' into bibo2_touch
5bb35df 
* master:
  cleanup & fix st7920 simulator (add klipper support) (bigtreetech#705)
  Add detection of Mainboard firmware type( Marlin or Smoothieware), auto-detect LONG_FILENAME_HOST_SUPPORT, on-boardSD and serial_always_on option in config file & other bugfixes (bigtreetech#663)
  Aesthetics, language, configuration (bigtreetech#667)
  Fix send_cancel_gcode in abortPrinting (bigtreetech#672)
  Fix heater indexes (bigtreetech#670)
  RU language correction (bigtreetech#701)
  Fix a few typos and add missing translations (bigtreetech#694)
jeffeb3 pushed a commit to jeffeb3/BIGTREETECH-TouchScreenFirmware that referenced this pull request Jul 20, 2020
@rebel1
Fix send_cancel_gcode in abortPrinting (bigtreetech#672)
7c982ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rebel1 @guruathwal @thisiskeithb @digant73 @bigtreetech