Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"G29" "A" or "D" fix & number bit operation clean up #2603

Merged
merged 24 commits into from
Feb 10, 2023

Conversation

kisslorand
Copy link
Contributor

@kisslorand kisslorand commented Sep 19, 2022

Requirements

BTT or MKS TFT

Description

  • duplicate code removal
  • modulo/modulus with "2" to bitwise operation
  • removed unnecessary serial communication after homing
  • fixed "G29" command "A" and "D" parameter parsing in case of Marlin firmware, applicable only for UBL
  • fixed a typo in "Print.c"

Later mods:

Benefits

  • smaller FW size
  • no unwanted/accidental bed level enabling/disabling

Related Issues

If "G29" had "A" or "D" parameter, bed leveling was enabled or disabled regardless of the bed leveling type. In case of UBL it's a wrong assumption that the printer will be able to execute those commands, these settings must be set based on the printer's feedback. In case the bed leveling is not UBL type, those parameters ("A", "D") have different meaning, not related to enabling or disabling the bed leveling.

@kisslorand kisslorand mentioned this pull request Sep 19, 2022
@kisslorand kisslorand mentioned this pull request Nov 24, 2022
@bigtreetech bigtreetech changed the title Some fixes "G29" "A" or "D" fix & number bit operation clean up Feb 9, 2023
@bigtreetech bigtreetech merged commit 5b8f1d6 into bigtreetech:master Feb 10, 2023
kisslorand added a commit to kisslorand/BIGTREETECH-TFT that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants