Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup macros #2593

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Popup macros #2593

merged 3 commits into from
Sep 14, 2022

Conversation

kisslorand
Copy link
Contributor

  • macros with parameter descriptions for all popup types (dialog, reminder, splash)
  • tiny code reduction

@bigtreetech bigtreetech merged commit 719103b into bigtreetech:master Sep 14, 2022
@rondlh
Copy link

rondlh commented Sep 18, 2022

It would have been nice to also correct this typo in print.c:

  // confirm file selction

It should be "selection" of course.

@kisslorand
Copy link
Contributor Author

@rondlh
Fixed in PR #2603. Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants