Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation 3xx redirects can't send headers #2904

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

MichaelWest22
Copy link
Contributor

@MichaelWest22 MichaelWest22 commented Sep 13, 2024

Description

Added some documentation for how response headers are not received or processed when 3xx response codes are returned.

Corresponding issue:
#2879

Testing

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@MichaelWest22 MichaelWest22 changed the title 3xx redirects can't send headers Documentation 3xx redirects can't send headers Sep 13, 2024
Copy link
Collaborator

@Telroshan Telroshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition for a very common gotcha!

@@ -1028,13 +1028,13 @@ htmx includes a number of useful headers in requests:
| `HX-Trigger-Name` | the `name` of the triggered element if it exists
| `HX-Trigger` | the `id` of the triggered element if it exists

### Response Headers
### Response Headers {#response_headers}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to break the default anchor that was response-headers and referenced at 2 other places in this file.
Ran zola serve and got 2 errors, I'd say either replace this by response-headers or replace the 2 existing usages by response_headers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sorry I missed those two existing links. should be fixed now

@Telroshan Telroshan added the documentation Improvements or additions to documentation label Sep 14, 2024
@Telroshan
Copy link
Collaborator

Perfect thanks!

@Telroshan Telroshan merged commit 6ce6a1a into bigskysoftware:master Sep 15, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants