-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document that HX-Trigger headers are ignored on 302s #2879
Comments
Hey, yep as said in the issue you linked
So this affects PRs are always welcome to improve the documentation, if you feel like it! |
Added some documentation around this in a PR for review. One thing I noticed when testing and reviewing the code for how htmx handles the headers is that we have a couple of duplications in the checking and handling of the HX-Retarget and HX-Reswap headers. see dev...MichaelWest22:htmx:duplicate-header-checks where I tested removing the duplicates and I checked carefully that the first header fetches were indeed not required. No major perf gain removing them just makes the code more readable. |
@boosh updated documentation is now live can you check and close the issue if your happy with it? |
LGTM thanks |
Please clearly document that
HX-Trigger
won't trigger events on endpoints that return redirects (#2052)The text was updated successfully, but these errors were encountered: