[WIP] Use specificaiton schemas to generate regex. #1126
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As PRs like bids-standard/bids-specification#424 become more common, and require the regex in the validator to be updated, and as the regex gets more and more complicated it might be good to move towards automatically generated regex.
This adds a directory called schemas to the validator that has a complete set of the specifications schema files copied with cp from the current master specification. The index.js file in that directory will attempt to generate appropriate regex for valid filenames from the yaml files.
Thoughts and todos: