Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version to 1.3.0-dev #234

Merged
merged 3 commits into from
May 17, 2019
Merged

Conversation

effigies
Copy link
Collaborator

Closes #233.

@franklin-feingold If you have a process for generating the before/after figures, could you change them to 1.2.0-dev -> 1.2.0 and 1.2.0 -> 1.3.0-dev, or similar?

@franklin-feingold
Copy link
Collaborator

added in the before/after images for the release protocol - effigies#1

@franklin-feingold franklin-feingold self-requested a review May 16, 2019 23:20
@effigies
Copy link
Collaborator Author

Sorry, I rebased to get rid of a bunch of ugly merge commits, so I'll need new reviews.

I'm doing a rewrite of the release protocol that's a bit heavier on exact git commands. That can go in this or wait for a new PR, whichever y'all prefer.

@franklin-feingold
Copy link
Collaborator

I don't have a preference for either option. I think it can go into this one unless it will take some time to flesh out then it can go into the next one

@effigies
Copy link
Collaborator Author

Nah, should finish in the morning. Just a question of whether you want to potentially do back and forth on this PR.

@franklin-feingold
Copy link
Collaborator

oh! it may be good in that case to separate the two for historical tracking, we can have one PR changing the dev name and another to do the release protocol rewrite

@effigies
Copy link
Collaborator Author

Yeah, I think I'm going to propose some potentially substantive changes to the release procedure, so we should split it from this.

@effigies effigies merged commit ddedf0c into bids-standard:master May 17, 2019
@effigies effigies deleted the maint/dev_version branch May 17, 2019 16:45
@sappelhoff sappelhoff changed the title REL: 1.3.0-dev bump version to 1.3.0-dev Oct 23, 2022
@sappelhoff sappelhoff added the exclude-from-changelog This item will not feature in the automatically generated changelog label Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INFRA] Latest version shows 1.2.0-dev
3 participants