Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Latest version shows 1.2.0-dev #233

Closed
effigies opened this issue May 16, 2019 · 3 comments · Fixed by #234
Closed

[INFRA] Latest version shows 1.2.0-dev #233

effigies opened this issue May 16, 2019 · 3 comments · Fixed by #234

Comments

@effigies
Copy link
Collaborator

In most cases the -dev suffix is considered pre-release state, so 1.2.0-dev is for versions leading up to the 1.2.0 release. We are post-1.2.0, but the listed version is 1.2.0-dev.

Do we consider this a problem?

@sappelhoff
Copy link
Member

I consider this to be how it should be: Our most recent stable version is 1.2.0, and the latest version is like master, which is where further development happens based on our most recent stable version --> 1.2.0-dev.

Or should it be 1.3.0-dev, because we are providing the development version of our upcoming release?

@effigies
Copy link
Collaborator Author

Or should it be 1.3.0-dev, because we are providing the development version of our upcoming release?

This is what I would expect from a semver perspective.

@sappelhoff
Copy link
Member

+1 then to change this and also adjust it in the step 5 of the release protocol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants