-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BEP-038: Atlases #1714
base: master
Are you sure you want to change the base?
BEP-038: Atlases #1714
Conversation
I made a first draft of the atlas BEP based on the Google doc
Added atlas content
All the content of the BEP038 Google document has been ported to the atlas.md file. Additionally atlas and a definition of what of means was added as an entity. There are still smaller things to fix as some links, references and the tables still need to be inserted.
Fixed details such as linking to entities and suffixes as well as clarified some of the example text. The tables need still to be fixed.
[BEP038] Style and similar cleanups
@erdalkaraca @tsalo this has passed the review period now, can this be checked and merged? thx |
I'm working on a review. Please hold on. |
I also have not finished my review/proposed changes. I am unlikely to get to it before the meeting next week as I am traveling for another meeting this week. |
This BEP currently needs:
I'm converting this to draft to reflect this status. I'm going to temporarily restrict comments, pending synchronous discussion. |
Hi, Folks, Thanks for helping with this BEP. It was great to see several of you at OHB< I would like to kindly ask to go back to this BEP and make a decision before OHBM. We have a few proposals to pick from (see here), most of them would be fine with @PeerHerholz and myself. What are the pending issues that would need to be resolved? @effigies @CPernet @oesteban @PeerHerholz @melanieganz @sappelhoff @christinerogers @tsalo @erdalkaraca @jdkent |
This PR proposes the inclusion of BEP-038 into the BIDS specification.
The BEP is hosted on its own branch in the main repository, and BEP leads have been given write permissions to the branch. If you are a BEP lead and having issues writing to the branch, please let a maintainer know and we can make sure you have access.
At present this is a starting point, and I anticipate significant rewriting and reorganization before final merge. There is extensive discussion in #1281 that needs to be turned into concrete proposals. I would suggest keeping the discussion on this PR minimal so that newcomers can follow the thread. When opening PRs against this branch, please include a reference to this PR (
#1714
) so that it shows up in the thread.Rendered draft
https://bids-specification--1714.org.readthedocs.build/en/1714/atlas.html
Related discussions