Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] pin dependencies for docker build #59

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Dec 14, 2023

closes #51

  • add a requirements.txt generated from a pip freeze to be used during the docker build
  • freeze non python dependencies used during docker build
  • pin docker base image with sha256

@codecov-commenter
Copy link

Codecov Report

Merging #59 (8871f33) into main (916e155) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   91.31%   91.31%           
=======================================
  Files           9        9           
  Lines         449      449           
=======================================
  Hits          410      410           
  Misses         39       39           

Copy link
Collaborator

@htwangtw htwangtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this one in...

@htwangtw htwangtw merged commit 4f0f28c into bids-apps:main Dec 14, 2023
11 checks passed
@Remi-Gau Remi-Gau deleted the pin_dependencies branch December 14, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pin "dependencies"
3 participants