Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin "dependencies" #51

Closed
Remi-Gau opened this issue Oct 16, 2023 · 0 comments · Fixed by #59
Closed

pin "dependencies" #51

Remi-Gau opened this issue Oct 16, 2023 · 0 comments · Fixed by #59

Comments

@Remi-Gau
Copy link
Collaborator

if this is meant to be used as an app I would have pretty strict pinning policy where I would explicitly specify the version of all direct dependencies at least with a == and possibly also that of all transitive dependencies with a pip freeze

also it seems that dependencies are installed "twice" in the docker recipe:

RUN pip3 install nilearn==0.9.2 templateflow pybids h5py tqdm&& \
    mkdir -p /code && mkdir -p /templateflow        <-- first install

WORKDIR /code

RUN python3 -c "from templateflow.api import get; get(['MNI152NLin2009cAsym', 'MNI152NLin6Asym'])"

COPY [".", "/code"]

RUN pip install --upgrade pip && pip3 install -e .         <-- second 'indirect' install

I would also probably pin version of the python base imaged used in the docker build to ensure reproducibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant