Skip to content
This repository has been archived by the owner on Oct 15, 2021. It is now read-only.

Support offset and size for read #157

Merged
merged 4 commits into from
Jul 22, 2021
Merged

Support offset and size for read #157

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b25dce
Support offset and size for read
zhaohuxing Jul 22, 2021
74c6fab
Check the size and correct range end for read
zhaohuxing Jul 22, 2021
d8fe1f7
Use HasOffset and HasSize to check offset and size
zhaohuxing Jul 22, 2021
7194058
Compatible with only size or offset
zhaohuxing Jul 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,9 @@ func (s *Storage) read(ctx context.Context, path string, w io.Writer, opt pairSt
Bucket: aws.String(s.name),
Key: aws.String(rp),
}
if opt.Size > 0 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use opt.HasXxxx to check size and offset.

It's OK to eliminate the check for offset, but please fill comments here for the reason.

Copy link
Contributor Author

@zhaohuxing zhaohuxing Jul 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified, Please Review.

input.Range = aws.String(fmt.Sprintf("bytes=%d-%d", opt.Offset, opt.Offset+opt.Size-1))
}
if opt.HasExceptedBucketOwner {
input.ExpectedBucketOwner = &opt.ExceptedBucketOwner
}
Expand Down