This repository has been archived by the owner on Oct 15, 2021. It is now read-only.
Support offset and size for read #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Jul 22, 2021
storage.go
Outdated
| @@ -473,6 +473,7 @@ func (s *Storage) read(ctx context.Context, path string, w io.Writer, opt pairSt | |||
| input := &s3.GetObjectInput{ | |||
| Bucket: aws.String(s.name), | |||
| Key: aws.String(rp), | |||
| Range: aws.String(fmt.Sprintf("bytes=%d-%d", opt.Offset, opt.Offset+opt.Size)), | |||
There was a problem hiding this comment.
Range is [a, b], maybe we need to use opt.Offset+opt.Size-1 for end?
There was a problem hiding this comment.
BTW, we need to check offset and size before we use them.
- What if the offset is missing?
- What if the size is missing?
There was a problem hiding this comment.
Rangeis[a, b], maybe we need to useopt.Offset+opt.Size-1for end?
Got
There was a problem hiding this comment.
BTW, we need to check offset and size before we use them.
- What if the offset is missing?
- What if the size is missing?
Both offset and size are not pointer types, so we have to check whether size is greater than 0
Xuanwo
reviewed
Jul 22, 2021
storage.go
Outdated
| @@ -474,6 +474,9 @@ func (s *Storage) read(ctx context.Context, path string, w io.Writer, opt pairSt | |||
| Bucket: aws.String(s.name), | |||
| Key: aws.String(rp), | |||
| } | |||
| if opt.Size > 0 { | |||
There was a problem hiding this comment.
Please use opt.HasXxxx to check size and offset.
It's OK to eliminate the check for offset, but please fill comments here for the reason.
There was a problem hiding this comment.
Modified, Please Review.
Xuanwo
reviewed
Jul 22, 2021
Xuanwo
approved these changes
Jul 22, 2021
This was referenced Jul 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.