Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

[2.x] Test Refactoring #450

Merged
merged 36 commits into from
Aug 14, 2020
Merged

[2.x] Test Refactoring #450

merged 36 commits into from
Aug 14, 2020

Conversation

rennokki
Copy link
Collaborator

No description provided.

@rennokki rennokki changed the base branch from master to 2.x August 13, 2020 11:25
@rennokki rennokki mentioned this pull request Aug 13, 2020
14 tasks
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2020

Codecov Report

Merging #450 into 2.x will increase coverage by 14.84%.
The diff coverage is 42.85%.

Impacted file tree graph

@@              Coverage Diff              @@
##                2.x     #450       +/-   ##
=============================================
+ Coverage     45.57%   60.41%   +14.84%     
- Complexity      337      338        +1     
=============================================
  Files            53       53               
  Lines          1389     1301       -88     
=============================================
+ Hits            633      786      +153     
+ Misses          756      515      -241     
Impacted Files Coverage Δ Complexity Δ
src/Console/StartWebSocketServer.php 77.01% <42.85%> (+72.24%) 19.00 <0.00> (+1.00)
src/Server/Logger/HttpLogger.php 0.00% <0.00%> (ø) 7.00% <0.00%> (ø%)
src/Server/Logger/WebsocketsLogger.php 0.00% <0.00%> (ø) 7.00% <0.00%> (ø%)
src/HttpApi/Controllers/TriggerEventController.php 0.00% <0.00%> (ø) 2.00% <0.00%> (ø%)
src/WebSocketsServiceProvider.php 70.49% <0.00%> (+1.63%) 9.00% <0.00%> (ø%)
src/PubSub/Drivers/LocalClient.php 96.55% <0.00%> (+6.89%) 11.00% <0.00%> (ø%)
src/Server/OriginCheck.php 20.00% <0.00%> (+20.00%) 10.00% <0.00%> (ø%)
src/Statistics/DnsResolver.php 40.00% <0.00%> (+40.00%) 5.00% <0.00%> (ø%)
src/Server/Logger/Logger.php 40.74% <0.00%> (+40.74%) 10.00% <0.00%> (ø%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 815eabc...4e9b526. Read the comment docs.

@rennokki rennokki merged commit 38b2e4d into 2.x Aug 14, 2020
@rennokki rennokki deleted the refactor/tests branch August 14, 2020 17:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants