This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 639
[refactor/tests] Added tests for Redis PubSub replication #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FWIW I called it "replication" because it's not purely pubsub due to having the channel methods in the interface. But no complaints from me, either is okay. |
Then I'll just revert the namings. I want something really concise. 🤔 |
…kets into refactor/pubsub-replication-tests
Just found out that tests can be done by using mocking. https://github.com/clue/reactphp-redis/blob/master/tests/FactoryLazyClientTest.php |
…code/laravel-websockets into refactor/pubsub-replication-tests
Codecov Report
@@ Coverage Diff @@
## refactor/tests #453 +/- ##
====================================================
+ Coverage 60.79% 70.19% +9.40%
====================================================
Files 53 53
Lines 1311 1171 -140
====================================================
+ Hits 797 822 +25
+ Misses 514 349 -165
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some changes to the PubSub replication PR (#140) introduced by @francislavoie
Currently, the tests are set up to run for both Local and Redis clients in the same CI pipeline.