Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields - Dgun compatibility fix #4113

Merged

Conversation

SethDGamre
Copy link
Collaborator

@SethDGamre SethDGamre commented Jan 4, 2025

somewhere along the development path dguns stopped interacting with shields correctly - and they never worked consistently. This PR fixes that and adds the DGun to the bitmask that can be stopped by the extra units t3 shields.

Unchanged:

  • Vanilla t2 shields don't block dgun

Changed:

  • dgun projectile now sits in the same spot as it grinds against a shield, rather than jumping back arbitrary distance like before. looks better and applies damage more consistently.
  • now works whether rework enabled or not consistently
  • t3 shields now block dgun (but it eats through them super fast)

Other:

  • GG.AddShieldDamage never worked due to being nested inside of a callin. I put it outside the callin and it now works. Ended up not using it, though.

Tested both vanilla modoptions and shield rework enabled in a crazy coop vs scavs game to check for crashes

@Damgam Damgam merged commit 09bdb66 into beyond-all-reason:master Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants