Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Mex building deselection in default buildmenu #2654

Merged

Conversation

thehobojoe
Copy link
Contributor

Work done

Buildmenu doesn't do any shift handling, but it still behaves like this
If using the default build menu:

  • with a building selected, you can press and release shift and nothing happens
  • With a building selected, you can place a building without shift, it will be queued and the building will be deselected
  • With a building selected, you can place it with shift, it will be queued and the building will remain selected
  • AFTER placing a building with shift, releasing shift will deselect the building.

I cannot find any code that matches the described behavior here, so I suspect it's set in the engine somewhere. I manually handle shift and building deselection in extractor_snap to get around this.

@thehobojoe thehobojoe merged commit 567d42c into beyond-all-reason:master Feb 24, 2024
@thehobojoe thehobojoe deleted the mex-deselect-default branch March 13, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant