default 16bit rgb/rgba textures to unorm instead of uint #9611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
Elabajaba
reviewed
Sep 1, 2023
| @@ -88,7 +88,7 @@ pub fn dds_format_to_texture_format( | |||
| TextureFormat::Bc3RgbaUnorm | |||
| } | |||
| } | |||
| D3DFormat::A16B16G16R16 => TextureFormat::Rgba16Uint, | |||
| D3DFormat::A16B16G16R16 => TextureFormat::Rgba16Unorm, | |||
There was a problem hiding this comment.
Checked the microsoft docs and it seems like A16B16G16R16 is an old dx9 format and the dx11 equivalent is DXGI_FORMAT_R16G16B16A16_UNORM, so this seems correct.
|
|
||
| data = local_data; | ||
| data = cast_slice(&raw_data).to_owned(); |
There was a problem hiding this comment.
Should this potentially be in an unsafe block?
There was a problem hiding this comment.
do you mean make Image::from_dynamic unsafe? i don't think it's necessary, the worst that'll happen is garbage pixeldata in your image.
mockersf
approved these changes
Sep 5, 2023
mockersf
added
the
S-Ready-For-Final-Review
This was referenced Sep 9, 2023
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
…9611) # Objective fix bevyengine#8185, bevyengine#6710 replace bevyengine#7005 (closed) rgb and rgba 16 bit textures currently default to `Rgba16Uint`, the more common use is `Rgba16Unorm`, which also matches the default type of rgb8 and rgba8 textures. ## Solution Change default to `Rgba16Unorm`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
fix #8185, #6710
replace #7005 (closed)
rgb and rgba 16 bit textures currently default to
Rgba16Uint, the more common use isRgba16Unorm, which also matches the default type of rgb8 and rgba8 textures.Solution
Change default to
Rgba16Unorm