[Merged by Bors] - Add TextureFormat::Rg16Unorm support for Image and derive Resource for SpecializedComputePipelines #5991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
approved these changes
Sep 15, 2022
alice-i-cecile
added
the
C-Usability
bors bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
…r SpecializedComputePipelines (#5991) # Objective Currently some TextureFormats are not supported by the Image type. The `TextureFormat::Rg16Unorm` format is useful for storing minmax heightmaps. Similar to #5249 I now additionally require image to support the dual channel variant. ## Solution Added `TextureFormat::Rg16Unorm` support to Image. Additionally this PR derives `Resource` for `SpecializedComputePipelines`, because for some reason this was missing. All other special pipelines do derive `Resource` already. Co-authored-by: Kurt Kühnert <[email protected]>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
…r SpecializedComputePipelines (bevyengine#5991) # Objective Currently some TextureFormats are not supported by the Image type. The `TextureFormat::Rg16Unorm` format is useful for storing minmax heightmaps. Similar to bevyengine#5249 I now additionally require image to support the dual channel variant. ## Solution Added `TextureFormat::Rg16Unorm` support to Image. Additionally this PR derives `Resource` for `SpecializedComputePipelines`, because for some reason this was missing. All other special pipelines do derive `Resource` already. Co-authored-by: Kurt Kühnert <[email protected]>
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…r SpecializedComputePipelines (bevyengine#5991) # Objective Currently some TextureFormats are not supported by the Image type. The `TextureFormat::Rg16Unorm` format is useful for storing minmax heightmaps. Similar to bevyengine#5249 I now additionally require image to support the dual channel variant. ## Solution Added `TextureFormat::Rg16Unorm` support to Image. Additionally this PR derives `Resource` for `SpecializedComputePipelines`, because for some reason this was missing. All other special pipelines do derive `Resource` already. Co-authored-by: Kurt Kühnert <[email protected]>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…r SpecializedComputePipelines (bevyengine#5991) # Objective Currently some TextureFormats are not supported by the Image type. The `TextureFormat::Rg16Unorm` format is useful for storing minmax heightmaps. Similar to bevyengine#5249 I now additionally require image to support the dual channel variant. ## Solution Added `TextureFormat::Rg16Unorm` support to Image. Additionally this PR derives `Resource` for `SpecializedComputePipelines`, because for some reason this was missing. All other special pipelines do derive `Resource` already. Co-authored-by: Kurt Kühnert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Currently some TextureFormats are not supported by the Image type.
The
TextureFormat::Rg16Unormformat is useful for storing minmax heightmaps.Similar to #5249 I now additionally require image to support the dual channel variant.
Solution
Added
TextureFormat::Rg16Unormsupport to Image.Additionally this PR derives
ResourceforSpecializedComputePipelines, because for some reason this was missing.All other special pipelines do derive
Resourcealready.