Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Spherical area lights example #3498

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Spherical area lights example #3498

wants to merge 2 commits into from

Conversation

cart
Copy link
Member

@cart cart commented Dec 30, 2021

I was putting together the Bevy 0.6 release blog post and wanted a simple area light radius example, so here we are :)

image

@cart cart added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples labels Dec 30, 2021
@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 30, 2021
jakobhellermann
jakobhellermann approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@jakobhellermann jakobhellermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Triage This issue needs to be labelled labels Dec 30, 2021
@alice-i-cecile
Copy link
Member

Code quality and clarity are great as always. LGTM!

@cart
Copy link
Member Author

cart commented Dec 30, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 30, 2021
@cart
Spherical area lights example (#3498)
f2aba02 
I was putting together the Bevy 0.6 release blog post and wanted a simple area light radius example, so here we are :)

![image](https://user-images.githubusercontent.com/2694663/147786883-63454290-b5b1-4456-9762-0b0b47e16bb5.png)
@bors
Copy link
Contributor

bors bot commented Dec 30, 2021

Build failed:

@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Dec 30, 2021
@cart
Spherical area lights example (#3498)
1d0d8a3 
I was putting together the Bevy 0.6 release blog post and wanted a simple area light radius example, so here we are :)

![image](https://user-images.githubusercontent.com/2694663/147786883-63454290-b5b1-4456-9762-0b0b47e16bb5.png)
@mockersf
Copy link
Member

(link failure on reddit)

@bors
Copy link
Contributor

bors bot commented Dec 30, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Spherical area lights example [Merged by Bors] - Spherical area lights example Dec 30, 2021
@bors bors bot closed this Dec 30, 2021
mockersf pushed a commit to mockersf/bevy that referenced this pull request Jan 1, 2022
@cart @mockersf
Spherical area lights example (bevyengine#3498)
66b8827 
I was putting together the Bevy 0.6 release blog post and wanted a simple area light radius example, so here we are :)

![image](https://user-images.githubusercontent.com/2694663/147786883-63454290-b5b1-4456-9762-0b0b47e16bb5.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobhellermann jakobhellermann jakobhellermann approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cart @alice-i-cecile @mockersf @jakobhellermann