-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derive PartialEq, Serialize, Deserialize and Reflect on primitives #11514
Derive PartialEq, Serialize, Deserialize and Reflect on primitives #11514
Conversation
Deriving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Could we maybe move these files into a new math
module? That way we can group it with the rect
and glam
modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since they're sort of behind different features, I kept glam separate from math, but grouped all the bevy_math stuff together ... We could also change the features so glam is the same feature (tho that might be really annoying if anyone uses glam and bevy_reflect, but not bevy_math outside of bevy)
c93b6b3
to
0c40b8e
Compare
I fixed the serialize thing on primitives with a fairly common workaround, but implementing Reflect for Also not quite sure why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once dead code is cleaned up. It's annoying that we can't just use the derive macro, but circular dependencies are real.
…evyengine#11514) # Objective - Implement common traits on primitives ## Solution - Derive PartialEq on types that were missing it. - Derive Copy on small types that were missing it. - Derive Serialize/Deserialize if the feature on bevy_math is enabled. - Add a lot of cursed stuff to the bevy_reflect `impls` module.
Objective
Solution
impls
module.