Fix/default value property id bug page 4706 #3459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingmar-stipriaan
previously approved these changes
Sep 10, 2024
| @@ -150,6 +150,9 @@ | |||
| ) { | |||
| return parsed.map((obj) => String(obj.id)); | |||
| } | |||
| if (typeof parsed === 'number') { | |||
| return [parsed]; | |||
There was a problem hiding this comment.
agree that this name isn't great. I've changed it to parsedValue in latest commit, so it makes a bit more sense.
jrquak
previously approved these changes
Sep 10, 2024
dylanBetty
dismissed stale reviews from jrquak and ingmar-stipriaan
via
eb76ef0
jrquak
approved these changes
Sep 10, 2024
ingmar-stipriaan
approved these changes
Sep 10, 2024
|
🎉 This PR is included in version 2.190.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.