Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add positional DOP to GUI #3857

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Add positional DOP to GUI #3857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d376222
Display positional DOP
haslinghuis Mar 24, 2024
109e0f5
Fix DOP presentation
haslinghuis Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions locales/en/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2839,6 +2839,9 @@
"gpsDistToHome": {
"message": "Dist to Home:"
},
"gpsPositionalDop": {
"message": "Positional DOP:"
},
"gpsSignalStrHead": {
"message": "GPS Signal Strength"
},
Expand Down
1 change: 1 addition & 0 deletions src/js/VirtualFC.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ const sampleGpsData = {
"alt": 0,
"speed": 0,
"ground_course": 1337,
"positionalDop": 0,
"distanceToHome": 0,
"directionToHome": 0,
"update": 0,
Expand Down
1 change: 1 addition & 0 deletions src/js/fc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,7 @@ const FC = {
alt: 0,
speed: 0,
ground_course: 0,
positionalDop: 0,
distanceToHome: 0,
directionToHome: 0,
update: 0,
Expand Down
3 changes: 3 additions & 0 deletions src/js/msp/MSPHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,9 @@ MspHelper.prototype.process_data = function(dataHandler) {
FC.GPS_DATA.alt = data.readU16();
FC.GPS_DATA.speed = data.readU16();
FC.GPS_DATA.ground_course = data.readU16();
if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_46)) {
FC.GPS_DATA.positionalDop = data.readU16();
}
break;
case MSPCodes.MSP_COMP_GPS:
FC.GPS_DATA.distanceToHome = data.readU16();
Expand Down
7 changes: 7 additions & 0 deletions src/js/tabs/gps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,13 @@ gps.initialize = async function (callback) {
$('.GPS_info td.sats').text(FC.GPS_DATA.numSat);
$('.GPS_info td.distToHome').text(`${FC.GPS_DATA.distanceToHome} m`);

if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_46)) {
const positionalDop = FC.GPS_DATA.positionalDop / 100;
$('.GPS_info td.positionalDop').text(`${positionalDop.toFixed(2)}`);
} else {
$('.GPS_info td.positionalDop').parent().hide();
}

// Update GPS Signal Strengths
const eSsTable = $('div.GPS_signal_strength table');

Expand Down
4 changes: 4 additions & 0 deletions src/tabs/gps.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@
<td i18n="gpsDistToHome"></td>
<td class="distToHome"></td>
</tr>
<tr>
<td i18n="gpsPositionalDop"></td>
<td class="positionalDop"></td>
</tr>
</table>
</div>
</div>
Expand Down