Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add positional DOP to GUI #3857

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Conversation

haslinghuis
Copy link
Member

image

@haslinghuis haslinghuis added this to the 10.10.0 milestone Mar 24, 2024

This comment has been minimized.

This comment has been minimized.

@HThuren
Copy link
Member

HThuren commented Mar 25, 2024

Not sure what this will show ?
Look into firmware do not help.

@ctzsnooze
Copy link
Member

ctzsnooze commented Mar 26, 2024

@haslinghuis thank you very much! TESTED: It works great!

The only thing to consider is that in the UBlox documentation, the value they describe is 100 times smaller than what we use. For instance, a value of 220 in our code means a pDOP of 2.20 in UBLox terms.

The 'meaning' of 2.2 in UBLox terms is that the expected 3D accuracy should be within 2.2 times the specified accuracy of the module. If module accuracy is specified as +/- 1.5m, then we would expect accuracy within 2.2 * 1.5m.

Hence it would be nice to format the value 220 as 2.20, if possible. In the image below, 1.43.

Screen Shot 2024-03-26 at 1 58 47 pm

@HThuren
Copy link
Member

HThuren commented Mar 26, 2024

If this is right, do we have a value going from 0 to 5 ?
If so, we might reflect this understanding
image
https://portal.u-blox.com/s/question/0D52p00008HKDx1CAH/3d-acc-pdop-and-hdop

Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for origin-betaflight-configurator failed.

Name Link
🔨 Latest commit 4e02858
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-configurator/deploys/6602ae6e69f6c00008b73b49

Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for origin-betaflight-configurator failed.

Name Link
🔨 Latest commit 109e0f5
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-configurator/deploys/6602ae7cd1b9cf0008f29c36

Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Linux
Betaflight-Configurator-Android
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@HThuren
Copy link
Member

HThuren commented Mar 26, 2024

@haslinghuis my propsal was if value best shown as 'slider' from 0 to 5, just for better view (or I myself can try another day :-) )

@haslinghuis
Copy link
Member Author

For now it displays the same PDOP value as the OSD. We are looking into other fields for better presentation.

This PR should be ready now.

@nerdCopter
Copy link
Member

/100 makes more sense i suppose, but not a blocking factor for now.

@haslinghuis haslinghuis merged commit 1e49a12 into betaflight:master Mar 26, 2024
8 of 12 checks passed
@haslinghuis haslinghuis deleted the update-dop branch March 26, 2024 13:36
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
* Display positional DOP

* Fix DOP presentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

4 participants