Use bash shell in riscv-tools Makefile #734
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another option is adding SHELL := /bin/bash in the manycore makefiles. Likely there are other assumptions about bash built-in |
The Makefile currently uses &> which works in bash, but not other shells. On Ubuntu 20.04.6 LTS, `make` uses /bin/sh, which is a symlink to dash. dash does not support this syntax. This PR explicitly sets the shell to bash in the Makefile.
jackhumphries
changed the title
|
That's a better solution. I updated this PR accordingly (though only did it for the riscv-tools Makefile). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Makefile currently uses &> which works in bash, but not other shells. On Ubuntu 20.04.6 LTS,
makeuses /bin/sh, which is a symlink to dash. dash does not support this syntax.This PR explicitly sets the shell to bash in the Makefile.
Issue reported in black-parrot-hdk/zynq-parrot#106.