Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Again cherry pick amino snake case and comments #4

Merged

Conversation

jefft0
Copy link

@jefft0 jefft0 commented Oct 25, 2023

This PR is a repeat of PR #2. When I rebased branch with-gno-PRs against the latest master branch, it seems that these commits were removed. So we add them again.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (edea16a) 47.55% compared to head (91659e5) 54.04%.
Report is 3 commits behind head on with-gno-PRs.

Additional details and impacted files
@@               Coverage Diff                @@
##           with-gno-PRs       #4      +/-   ##
================================================
+ Coverage         47.55%   54.04%   +6.48%     
================================================
  Files               370       13     -357     
  Lines             62059     1584   -60475     
================================================
- Hits              29514      856   -28658     
+ Misses            30116      679   -29437     
+ Partials           2429       49    -2380     

see 357 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@D4ryl00 D4ryl00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jefft0 jefft0 merged commit 23d453e into with-gno-PRs Oct 25, 2023
66 of 69 checks passed
@jefft0 jefft0 deleted the chore/again-cherry-pick-Amino-snake_case-and-comments branch October 25, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants