Chore: cherry pick amino snake case and comments #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Thompson <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
…roto3MessagePartial Signed-off-by: Jeff Thompson <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: https://github.com/berty/gno is a fork of https://github.com/gnolang/gno . The
with-gno-PRsbranch will track the master branch, plus include improvements by Berty which haven't been merged into the gnolang repo. Therefore, in the short term, gnomobile will use thewith-gno-PRsbranch so that it can use these improvements.This PR is to be merged into the
with-gno-PRsbranch. We cherry-pick the commits from PR gnolang#1213 for Amino snake_case field names, and PR gnolang#1235 for Amino to pass Go comments to the .proto definition.