Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/geometry lod #172

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Feat/geometry lod #172

merged 3 commits into from
Apr 4, 2023

Conversation

nick-rv
Copy link
Collaborator

@nick-rv nick-rv commented Feb 21, 2023

No description provided.

@nick-rv nick-rv added the lod Level Of Detail label Feb 21, 2023
@nick-rv nick-rv added this to the XP_FLUX milestone Feb 21, 2023
@nick-rv nick-rv self-assigned this Feb 21, 2023
@nick-rv nick-rv marked this pull request as draft February 21, 2023 11:00
@github-actions
Copy link

github-actions bot commented Feb 21, 2023 •
edited
Loading

Code Coverage

Package Line Rate Health
github.com/CrunchyData/pg_featureserv/internal/api 89% ✔
github.com/CrunchyData/pg_featureserv/internal/conf 54% ❌
github.com/CrunchyData/pg_featureserv/internal/cql 67% ➖
github.com/CrunchyData/pg_featureserv/internal/data 63% ➖
github.com/CrunchyData/pg_featureserv/internal/service 68% ➖
github.com/CrunchyData/pg_featureserv/internal/ui 82% ✔
github.com/CrunchyData/pg_featureserv 22% ❌
Summary 69% (6145 / 8865) ➖

Minimum allowed line rate is 60%

benoitdm-oslandia
benoitdm-oslandia requested changes Feb 21, 2023
View reviewed changes
Copy link
Owner

@benoitdm-oslandia benoitdm-oslandia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some minor corrections! Good job!

internal/data/feature_mock.go Show resolved Hide resolved
internal/data/feature_mock.go Outdated Show resolved Hide resolved
internal/data/feature_mock.go Outdated Show resolved Hide resolved
internal/service/db_test/handler_db_lod_test.go Outdated Show resolved Hide resolved
internal/service/db_test/handler_db_lod_test.go Outdated Show resolved Hide resolved
internal/service/db_test/handler_db_lod_test.go Outdated Show resolved Hide resolved
internal/service/handler.go Show resolved Hide resolved
internal/service/param.go Show resolved Hide resolved
internal/utiltest/test_db.go Outdated Show resolved Hide resolved
internal/utiltest/test_db.go Outdated Show resolved Hide resolved
@benoitdm-oslandia
Copy link
Owner

Last thing: can you add some documentation about how using this query parameter? What does it mean when a small value is used or a big one?

@nick-rv nick-rv force-pushed the feat/geometry-lod branch 2 times, most recently from 5657204 to b26c906 Compare February 25, 2023 03:51
@benoitdm-oslandia benoitdm-oslandia marked this pull request as ready for review February 27, 2023 08:03
benoitdm-oslandia
benoitdm-oslandia requested changes Feb 27, 2023
View reviewed changes
Copy link
Owner

@benoitdm-oslandia benoitdm-oslandia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrat! Only 4 remaining comments and we will merge!

internal/api/openapi.go Outdated Show resolved Hide resolved
internal/utiltest/test_db.go Outdated Show resolved Hide resolved
@nick-rv nick-rv linked an issue Feb 27, 2023 that may be closed by this pull request
Task - Generate simplified geometry on-the-fly for returned objets - impl #155
Closed
benoitdm-oslandia
benoitdm-oslandia previously approved these changes Feb 28, 2023
View reviewed changes
Copy link
Owner

@benoitdm-oslandia benoitdm-oslandia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will wait a bit for CrunchyData before merging

@benoitdm-oslandia benoitdm-oslandia removed the request for review from azarz March 2, 2023 09:28
@benoitdm-oslandia benoitdm-oslandia force-pushed the feat/geometry-lod branch 3 times, most recently from 63720d5 to 574a5b0 Compare April 4, 2023 14:34
benoitdm-oslandia
benoitdm-oslandia previously approved these changes Apr 4, 2023
View reviewed changes
Copy link
Owner

@benoitdm-oslandia benoitdm-oslandia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@benoitdm-oslandia benoitdm-oslandia merged commit b25400c into develop Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitdm-oslandia benoitdm-oslandia benoitdm-oslandia approved these changes

Assignees

@nick-rv nick-rv

Labels
lod Level Of Detail
Projects
OGC API - Features - Part 4
Status: ✅ Done
Milestone
XP_FLUX
Development

Successfully merging this pull request may close these issues.

Task - Generate simplified geometry on-the-fly for returned objets - impl
2 participants
@nick-rv @benoitdm-oslandia