feat: update internal/api/openapi.go

* Review debug
benoitdm-oslandia · Apr 4, 2023 · b25400c · b25400c
1 parent a0ed758
commit b25400c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/hugo/content/examples/ex_query_data.md b/hugo/content/examples/ex_query_data.md
@@ -94,4 +94,3 @@ The simplification operation is done using the Douglas-Peucker algorithm.
 http://localhost:9001/collections/ne.countries/items/55
 ?max-allowable-offset=0.1
 ```
-
diff --git a/internal/api/openapi.go b/internal/api/openapi.go
@@ -508,7 +508,7 @@ func GetOpenAPIContent(urlBase string) *openapi3.T {
 			Required:    false,
 			Schema: &openapi3.SchemaRef{
 				Value: &openapi3.Schema{
-					Type:    "integer",
+					Type:    "number",
 					Min:     openapi3.Float64Ptr(0),
 					Max:     openapi3.Float64Ptr(float64(conf.Configuration.Paging.LimitMax)),
 					Default: conf.Configuration.Paging.LimitDefault,

diff --git a/internal/service/db_test/handler_db_lod_test.go b/internal/service/db_test/handler_db_lod_test.go
@@ -65,8 +65,8 @@ func (t *DbTests) TestGeometrySimplificationSeveralFeatures() {
 // Test case with negative value as simplification factor
 func (t *DbTests) TestGeometrySimplificationNegativeValue() {
 	t.Test.Run("TestGeometrySimplificationNegativeValue", func(t *testing.T) {
-		path := "/collections/mock_poly/items/6?max-allowable-offset=-0.01"
-		// If lower thant minVal, then minValue (0) is considered
+		path := "/collections/mock_poly/items/1?max-allowable-offset=-0.01"
+		// If lower than minVal, then minValue (0) is considered
 		hTest.DoRequestMethodStatus(t, "GET", path, nil, nil, http.StatusOK)
 	})
 }
@@ -82,21 +82,21 @@ func (t *DbTests) TestGeometrySimplificationWrongFloatSeparatorValue() {
 // Test case with various values as simplification factor
 func (t *DbTests) TestGeometrySimplificationVariousSimplificationValues() {
 	t.Test.Run("TestGeometrySimplificationVariousSimplificationValues", func(t *testing.T) {
-		path := "/collections/mock_poly/items/4?max-allowable-offset=0.01"
+		path := "/collections/mock_poly/items/1?max-allowable-offset=0.01"
 		rr := hTest.DoRequestMethodStatus(t, "GET", path, nil, nil, http.StatusOK)
 		// Feature collection
 		var feat api.GeojsonFeatureData
 		errUnMarsh := json.Unmarshal(hTest.ReadBody(rr), &feat)
 		util.Assert(t, errUnMarsh == nil, fmt.Sprintf("%v", errUnMarsh))
 		util.Equals(t, 4, len(feat.Geom.Geometry().(orb.Polygon)[0]), "wrong number of simplified coordinates")
 
-		path = "/collections/mock_poly/items/4?max-allowable-offset=0.001"
+		path = "/collections/mock_poly/items/1?max-allowable-offset=0.001"
 		rr = hTest.DoRequestMethodStatus(t, "GET", path, nil, nil, http.StatusOK)
 		errUnMarsh = json.Unmarshal(hTest.ReadBody(rr), &feat)
 		util.Assert(t, errUnMarsh == nil, fmt.Sprintf("%v", errUnMarsh))
 		util.Equals(t, 10, len(feat.Geom.Geometry().(orb.Polygon)[0]), "wrong number of simplified coordinates")
 
-		path = "/collections/mock_poly/items/4?max-allowable-offset=1"
+		path = "/collections/mock_poly/items/1?max-allowable-offset=1"
 		rr = hTest.DoRequestMethodStatus(t, "GET", path, nil, nil, http.StatusOK)
 		errUnMarsh = json.Unmarshal(hTest.ReadBody(rr), &feat)
 		util.Assert(t, errUnMarsh == nil, fmt.Sprintf("%v", errUnMarsh))

diff --git a/internal/utiltest/test_db.go b/internal/utiltest/test_db.go
@@ -88,7 +88,7 @@ func InsertSimpleDataset(db *pgxpool.Pool, schema string) {
 
 	// collections tables
 	type tableContent struct {
-		geometryType string
+		geometryType api.GeometryType
 		extent       api.Extent
 		nx           int
 		ny           int
Original file line number	Diff line number	Diff line change
Expand Up		@@ -94,4 +94,3 @@ The simplification operation is done using the Douglas-Peucker algorithm.
		http://localhost:9001/collections/ne.countries/items/55
		?max-allowable-offset=0.1
		```