Add more tests of chain expressions. #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to #766.
Three issues:
1. The ChainElement type is an abstract supertype of CallExpression and
MemberExpression, so `switch (n.type)` will always see either
"CallExpression" or "MemberExpression" and never "ChainElement".
2. We need to print {Member,Call}Expression the same way we print
Optional{Member,Call}Expression, at least until the latter types are
fully deprecated by all parsers.
3. The optionality logic for call expressions was slightly off. Whether a
?. is printed should not depend on the optionality of the callee. This
has been an issue since #511, per git blame.
eventualbuddha
approved these changes
Oct 12, 2020
|
@eventualbuddha Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #766, addressing a few issues:
The
ChainElementtype is an abstract supertype ofCallExpressionandMemberExpression(see Added ChainExpression type ast-types#399), soswitch (n.type)will always see either"CallExpression"or"MemberExpression"and never"ChainElement".We need to keep the printing of
{Member,Call}Expressionaligned with the printing ofOptional{Member,Call}Expression, at least until the latter types are fully deprecated by all parsers.The optionality logic for call expressions was slightly off. Whether a
?.is printed should not depend on the optionality ofn.callee. This has been an issue since Implement printer cases for Optional{Member,Call}Expression. #511, per git blame.