Added ChainExpression type #399
Conversation
|
@benjamn Can I get a review on this? |
There was a problem hiding this comment.
@ethancrook99 Thanks for getting this started!
Can you try to match the subtyping relationships for this type in the ESTree specification? I think ChainExpression should be an Expression rather than a MemberExpression, and have an expression field that's a ChainElement, which is the supertype of both MemberExpression and CallExpression.
The tools provided by ast-types should be able to capture those relationships, but feel free to ask questions if anything seems tricky.
|
@benjamn Sure, I'll get started on those changes! |
|
@benjamn I changed the definition for Do any changes need to be made to |
|
@benjamn I changed the supertype of |
|
Are you planning to merge this fix anytime soon? We're stuck with a yarn resolution for babel in the package to support react-docgen. |
There was a problem hiding this comment.
@ethancrook99 Thanks for continuing to work on this, and sorry for leaving you to figure out the key insight about multiple inheritance. That's one of the reasons I built this whole def system in the first place, instead of using ordinary JS prototypal inheritance, since prototypes allow for only single inheritance (with good reason, of course, but you really want multiple inheritance, or something like traits, for an AST type system like this).
Types can be built up incrementally, so we can avoid including the ChainElement functionality in def/core.
We should never see nor need to create an AST node with type "ChainElement", so this abstract type doesn't need to be buildable (or printable by Recast).
Since CallExpression and MemberExpression inherit from this type, and those types are not optional by default, the default value of the 'optional' field must be false. As a side benefit, I think this default gives more value to the (otherwise somewhat redundant) OptionalMemberExpression and OptionalCallExpression types, whose 'optional' fields are true by default, in contrast to the ordinary MemberExpression and CallExpression types.
|
Thanks for finishing that up and getting it merged! |
Added a new
ChainExpressiontype to line up with how [email protected] handles optional chaining. I leftOptionalChainExpressionbut marked it as deprecated for projects that use older babel versions.Meant to fix this issue