Restore pretty-printing TypeScript type T = {...} and interface T {...} semicolons between child members
#1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to PR #1157 that I caught while trying to regenerate the TypeScript declarations for ast-types, and noticed a bunch of (IMHO reasonable) semicolons going missing.
eventualbuddha
approved these changes
Dec 11, 2022
This reverts commit 808e539. I usually bump the main package version on the main/master branch after merging PRs, but I wanted the commit I published to npm (git tag v0.23.0-pr-1247, [email protected], npm dist-tag pr-1247) to appear in the Git history somewhere, even though this commit reverts it.
benjamn
deleted the
restore-pretty-printing-ts-object-type-semicolons
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1157 correctly stopped the Recast pretty-printer from adding unnecessary extra commas between the fields of object-like TypeScript declarations.
However, many/most TypeScript programmers would probably expect to see semicolons here instead of commas/nothing. We could make this configurable, but I'm not sure it's even controversial, so I'll wait for someone to ask.
This PR enables the Recast pretty-printer (which is only invoked when the AST changes enough to require reprinting) to print those semicolons properly.
The subtlety is to avoid printing extra semicolons, but we already have precedent for using
lastNonSpaceCharacterto determine what's already at the end of printedLinesoutput.