-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: additional commas in TsTypeLiteral #1157
fix: additional commas in TsTypeLiteral #1157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It'd be very useful to have a test that fails before the changes you've made. Mind doing that?
de3213d
to
5c660cf
Compare
Thanks! I just pushed a commit to add a test following a similar pattern as #1157 Against
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Will merge and do a release soon.
5c660cf
to
8e24cf6
Compare
Released in v0.21.2. |
Follow-up to PR #1157 that I caught while trying to regenerate the TypeScript declarations for ast-types, and noticed a bunch of (IMHO reasonable) semicolons going missing.
Follow-up to PR benjamn#1157 that I caught while trying to regenerate the TypeScript declarations for ast-types, and noticed a bunch of (IMHO reasonable) semicolons going missing.
This is very pretty similar to #868 but with
TsTypeLiteral
. We were working on a codemod that involves adding to atype
and it was resulting in syntactically incorrect code like this (notice the;,
):We were able to
patch-package
but I figured I would make an upstream fix. Thank you!