Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Skip to content #68

Merged
merged 1 commit into from
Nov 1, 2014
Merged

TASK: Skip to content #68

merged 1 commit into from
Nov 1, 2014

Conversation

SventB
Copy link
Contributor

@SventB SventB commented Oct 31, 2014

Resolves #63

@webian
Copy link
Contributor

webian commented Oct 31, 2014

Hi @SventB ,
I think that it's better if you use xlf for text "Skip to main content" instead of TS constant.
So it's easier to handle translations.

@SventB
Copy link
Contributor Author

SventB commented Oct 31, 2014

Hi @webian ,
thank you for your feedback. I've made it according @benjaminkott did it with the copyright text. But your suggestion seems eligible, because this text usually hasn't to be changed.

@benjaminkott What do you think?

@benjaminkott
Copy link
Owner

Hey @SventB and @webian, i agree with webian at this point. I don´t think what you need to adjust the text inside the link and for translation its easier to get it handled with xlf files.

To speed this up i will merge your changes @SventB and make the adjustments @webian suggested.

benjaminkott added a commit that referenced this pull request Nov 1, 2014
TASK: Skip to content - adjustments will follow
@benjaminkott benjaminkott merged commit 7d22518 into benjaminkott:master Nov 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip to content
3 participants