Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip to content #63

Closed
SventB opened this issue Oct 7, 2014 · 5 comments · Fixed by #68
Closed

Skip to content #63

SventB opened this issue Oct 7, 2014 · 5 comments · Fixed by #68

Comments

@SventB
Copy link
Contributor

SventB commented Oct 7, 2014

Many websites offer a link to skip to the content. This is useful for screen readers.
There is also a note on the Bootstrap website: http://getbootstrap.com/css/?#helper-classes-screen-readers

Do you want me to do this and commit the code?

@benjaminkott
Copy link
Owner

@SventB feel free to help improving the package, code is always welcome if its useful. in this case just go for it ;)

@SventB
Copy link
Contributor Author

SventB commented Oct 11, 2014

I think you have to give me the right to commit? I've tried to commit but I got the error

Commit failed (details follow):
Access to
'/benjaminkott/bootstrap_package/!svn/act/2e8f73b2-b18c-d84f-a849-7181234d4e0d'
forbidden

@benjaminkott
Copy link
Owner

@SventB sry for late reply i´m currently a bit busy. And sadly i will not.

But what you can do is to fork the package and do a pull-request after you are fine with your changes. If everything is fine i can merge them. Its mainly the way github works - i cannot just allow everyone do commit directly to this repository. It "could" end in a huge mess.

@SventB
Copy link
Contributor Author

SventB commented Oct 31, 2014

Thank you for explaining :)
I've forked your package now, implemented this little feature and committed it.

@benjaminkott
Copy link
Owner

@SventB as explained in the pull request ive adjusted the suggestions from @webian.

Thx a lot for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants