Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider: Link to startpage #64

Closed
SventB opened this issue Oct 11, 2014 · 1 comment
Closed

Slider: Link to startpage #64

SventB opened this issue Oct 11, 2014 · 1 comment

Comments

@SventB
Copy link
Contributor

SventB commented Oct 11, 2014

The prev and next link of the slider is a link to the startpage, e.g.

<a class="left carousel-control" href="#carousel-170" data-slide="prev">

On click it does not link to startpage, sure, because JavaScript prevents that, but for crawler bots or with deactivated JavaScript it links to the startpage.

The href attribute should contain the url of the current page, e.g.

<a class="left carousel-control" href="my-carousel-page.html#carousel-170" data-slide="prev">

Or you could disable base url (see #54), then it will be ok ;)

The "skip to content" link (see #63) will also not work with a base url. I have to write a solution in TypoScript instead of a simple f:link.page in Fluid.

@benjaminkott
Copy link
Owner

solved in 61a3fc8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants