Language menu auto-hides if there are no sys_language records #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The menu itself does not auto-configure for installed languages, but at least now it won't show up when bootstrap_package is installed on a site with no language records.
|
We have a conflict here - can you rebase your changeset please? |
|
@phvt auto hiding languages will provide various issues on multisites - we are currently not able to determine what languages are really available for a site (without parsing the whole tree). i will close this pr for now since we made meanwhile some useful additions for language handling, so it can easily be turned off or configured. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The menu itself does not auto-configure for actual language records in the website, but at
least now it won't show up when bootstrap_package is installed on a site with no language records.
See discussions in #30, #71 and #122