Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify language mapping #122

Closed
wants to merge 1 commit into from
Closed

Simplify language mapping #122

wants to merge 1 commit into from

Conversation

aimeos
Copy link
Contributor

@aimeos aimeos commented Dec 13, 2014

Another minor improvement to simplify the language mapping. Accoring to http://huuah.com/multi-language-setup-in-typo3/, we can also use the ISO language codes as parameters instead of the language UID number. Thus, we don't need an additional mapping in RealURL.

@benjaminkott
Copy link
Owner

hey @aimeos, thx for your patch. we had already discussed language handling a lot and i am thinking about this for half a year now to find a very good, simple solution.

What we need is a fully customizable automatic language menu and config settings instead trading one for another. But I have sadly not seen a proper solution on the internet that seems to be really user and "newbie" friendly.

A solution would be for example:

  • extend sys_language with language codes
  • make language codes configurable via tsconfig
  • somehow make the default language configurable, maybe via page record extend
  • read the stuff and generate a language menu automaticly
  • make the config automaticly depending on the settings above
  • set a strict rule to that, no default language (to prevent husteling with the unknown)

The goal should be to have a multilanguage site up and running without any code changes needed at all. In my oppinion there should be no need to have these settings versioned exept the language codes since they are hardly dependant on records and their overlays.

Had no time yet to play around with that codewise, but its on my todolist.
Reported Bugs about this feature: #30 #71 #65

What do you think about this?

@aimeos
Copy link
Contributor Author

aimeos commented Dec 15, 2014

Would be great if this would be possible. I've also struggled myself a lot with dynamic language handling in the past and didn't find a good solution either. My suggested patch therefore only tries to simplify things a little bit by removing the need for a duplicate sys_language_id / ISO code mapping until someone has found the perfect solution ;-)

@benjaminkott
Copy link
Owner

we already improved the configuration options, its still no the best we can reach but all language settings are not configurable via constants or adapting the language template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants