Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed getCommitFromGitHubAPIRequest to refer to GITHUB_API_URL #171

Merged
merged 3 commits into from
May 18, 2023

Conversation

srz-zumix
Copy link
Contributor

getCommitFromGitHubAPIRequest is currently only supported on api.github.com. Therefore, if the event is GitHub Enterprise and the commit cannot be retrieved by payload, it will fail to retrieve the commit.
(e.g. scheduled event)

To fix this, the following fixes have been made.

@srz-zumix
Copy link
Contributor Author

This and #169 fix will allow GitHub Enterprise Server and non pull_request events to be used.

src/extract.ts Outdated Show resolved Hide resolved
@ningziwen ningziwen requested a review from ktrz May 16, 2023 20:31
@ningziwen ningziwen merged commit 3dc9c9f into benchmark-action:master May 18, 2023
@srz-zumix srz-zumix deleted the feature/getOctokit branch May 18, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants