Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getServerUrl refers to the GITHUB_SERVER_URL environment variable #169

Merged
merged 4 commits into from
May 6, 2023

Conversation

srz-zumix
Copy link
Contributor

GitHub Enterprise Server 3.7 or earlier fails to resolve the server URL because the schedule event payload does not include repository.

Since the server URL can be got with the GITHUB_SERVER_URL environment variable, it is now referenced if it cannot be got from payload.

https://docs.github.com/en/[email protected]/admin/release-notes

For scheduled runs of GitHub Actions workflows, users will see additional information about the repository, organization, and enterprise within the payload for github.event.

Copy link
Member

@ningziwen ningziwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ningziwen ningziwen requested a review from ktrz May 3, 2023 07:43
@ningziwen ningziwen merged commit ee5f49d into benchmark-action:master May 6, 2023
@srz-zumix srz-zumix deleted the patch-1 branch May 8, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants